Python Updates 2022-06-01 (was: python3: 3.9 -> 3.10)#175805
Merged
Python Updates 2022-06-01 (was: python3: 3.9 -> 3.10)#175805
Conversation
3ad6e41 to
61fe055
Compare
This was referenced Jun 2, 2022
7761db6 to
08dc103
Compare
- disable on obsolete Python releases - add format
- add pythonImportsCheck - disable on obsolete Python releases
- add pythonImportsCheck - disable on obsolete Python releases
- disable on obsolete Python releases
- disable on obsolete Python releases - add pythonImportsCheck
- add pythonImportsCheck - disable failing test
Member
Author
|
The 416/416 Test #416: python_test ......................***Failed 1.72 sec
Testing TBinaryAccelerated
Starting Benchmarks
HolyMoley Standard = 0.810447
HolyMoley Acceler. = 0.043564
FastStruct Standard = 0.185290
FastStruct Acceler. = 0.015597
Testing TCompactAccelerated
Traceback (most recent call last):
File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 255, in <module>
do_test(TCompactProtocolAccelerated, TCompactProtocol)
File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 218, in do_test
Test(fast, slow).do_test()
File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 184, in do_test
self._check_read(rshuge)
File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 162, in _check_read
c.read(prot)
File "/build/thrift-0.16.0/build/test/py/gen-py-default/DebugProtoTest/ttypes.py", line 900, in read
iprot._fast_decode(self, iprot, [self.__class__, self.thrift_spec])
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
*** FAILED ***
LIBDIR: /build/thrift-0.16.0/lib/py/build/lib.linux-x86_64-3.10
PY_GEN: gen-py-default
SCRIPT: FastbinaryTest.py
----------------
Executing individual test scripts with various generated code directories
Directories to be tested: gen-py-default, gen-py-slots, gen-py-oldstyle, gen-py-no_utf8strings, gen-py-dynamic, gen-py-dynamicslots
Scripts to be tested: FastbinaryTest.py, TestFrozen.py, TestRenderedDoubleConstants.py, TSimpleJSONProtocolTest.py, SerializationTest.py, TestEof.py, TestSyntax.py, TestSocket.py
----------------
Testing script: /nix/store/ngxk330mm695j9gmrpzngj4v5fcdskzz-python3-3.10.4-env/bin/python3.10 /build/thrift-0.16.0/test/py/FastbinaryTest.py
----
Traceback (most recent call last):
File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 323, in <module>
sys.exit(main())
File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 302, in main
runScriptTest(options.libdir, options.gen_base, genpydir, script)
File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 103, in runScriptTest
raise Exception("Script subprocess failed, retcode=%d, args: %s" % (ret, ' '.join(script_args)))
Exception: Script subprocess failed, retcode=1, args: /nix/store/ngxk330mm695j9gmrpzngj4v5fcdskzz-python3-3.10.4-env/bin/python3.10 /build/thrift-0.16.0/test/py/FastbinaryTest.py |
Member
|
For now I disabled the |
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
13 tasks
Et7f3
reviewed
Apr 17, 2023
Comment on lines
-395
to
403
| ( let | ||
| my_toolz = python38.pkgs.buildPythonPackage rec { | ||
| my_toolz = python39.pkgs.buildPythonPackage rec { | ||
| pname = "toolz"; | ||
| version = "0.10.0"; | ||
|
|
||
| src = python38.pkgs.fetchPypi { | ||
| src = python39.pkgs.fetchPypi { | ||
| inherit pname version; |
Contributor
There was a problem hiding this comment.
Their is a leftover in this expression python38.withPackages (ps: [ps.numpy my_toolz]) Is it intentional ? Now It can be udpated to 3.10
Member
Author
There was a problem hiding this comment.
No, wasn't intentional. I apparently missed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First staging run after the 22.05 release. During this cycle we update
python3from 3.9 to 3.10, while still recursing into both versions.Reopened on python-updates so we have a jobset where we can build the resulting changes.
https://hydra.nixos.org/jobset/nixpkgs/python-updates