Skip to content

Python Updates 2022-06-01 (was: python3: 3.9 -> 3.10)#175805

Merged
mweinelt merged 179 commits intostagingfrom
python-updates
Jun 8, 2022
Merged

Python Updates 2022-06-01 (was: python3: 3.9 -> 3.10)#175805
mweinelt merged 179 commits intostagingfrom
python-updates

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jun 1, 2022

First staging run after the 22.05 release. During this cycle we update python3 from 3.9 to 3.10, while still recursing into both versions.

Reopened on python-updates so we have a jobset where we can build the resulting changes.

https://hydra.nixos.org/jobset/nixpkgs/python-updates

@mweinelt mweinelt requested a review from FRidh as a code owner June 1, 2022 19:09
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation labels Jun 1, 2022
@mweinelt mweinelt mentioned this pull request Jun 1, 2022
13 tasks
@mweinelt mweinelt requested a review from jonringer as a code owner June 1, 2022 23:05
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 1, 2022
@mweinelt
Copy link
Member Author

mweinelt commented Jun 8, 2022

The thrift package, which is a reverse-dep of arrow-cpp, fails during the python test. cc @bjornfor

416/416 Test #416: python_test ......................***Failed    1.72 sec
Testing TBinaryAccelerated
Starting Benchmarks
HolyMoley Standard = 0.810447
HolyMoley Acceler. = 0.043564
FastStruct Standard = 0.185290
FastStruct Acceler. = 0.015597
Testing TCompactAccelerated
Traceback (most recent call last):
  File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 255, in <module>
    do_test(TCompactProtocolAccelerated, TCompactProtocol)
  File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 218, in do_test
    Test(fast, slow).do_test()
  File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 184, in do_test
    self._check_read(rshuge)
  File "/build/thrift-0.16.0/test/py/FastbinaryTest.py", line 162, in _check_read
    c.read(prot)
  File "/build/thrift-0.16.0/build/test/py/gen-py-default/DebugProtoTest/ttypes.py", line 900, in read
    iprot._fast_decode(self, iprot, [self.__class__, self.thrift_spec])
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
*** FAILED ***
LIBDIR: /build/thrift-0.16.0/lib/py/build/lib.linux-x86_64-3.10
PY_GEN: gen-py-default
SCRIPT: FastbinaryTest.py
----------------
 Executing individual test scripts with various generated code directories
 Directories to be tested: gen-py-default, gen-py-slots, gen-py-oldstyle, gen-py-no_utf8strings, gen-py-dynamic, gen-py-dynamicslots
 Scripts to be tested: FastbinaryTest.py, TestFrozen.py, TestRenderedDoubleConstants.py, TSimpleJSONProtocolTest.py, SerializationTest.py, TestEof.py, TestSyntax.py, TestSocket.py
----------------

Testing script: /nix/store/ngxk330mm695j9gmrpzngj4v5fcdskzz-python3-3.10.4-env/bin/python3.10 /build/thrift-0.16.0/test/py/FastbinaryTest.py
----
Traceback (most recent call last):
  File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 323, in <module>
    sys.exit(main())
  File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 302, in main
    runScriptTest(options.libdir, options.gen_base, genpydir, script)
  File "/build/thrift-0.16.0/test/py/RunClientServer.py", line 103, in runScriptTest
    raise Exception("Script subprocess failed, retcode=%d, args: %s" % (ret, ' '.join(script_args)))
Exception: Script subprocess failed, retcode=1, args: /nix/store/ngxk330mm695j9gmrpzngj4v5fcdskzz-python3-3.10.4-env/bin/python3.10 /build/thrift-0.16.0/test/py/FastbinaryTest.py

@fabaff
Copy link
Member

fabaff commented Jun 8, 2022

For now I disabled the thrift tests which fail on Python 3.10. The upstream repo contains hints that at least partially the tests were migrated to Python 3.10.

@mweinelt mweinelt merged commit 351556f into staging Jun 8, 2022
@dotlambda dotlambda mentioned this pull request Jun 11, 2022
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-macos-monthly/12330/24

@cole-h cole-h mentioned this pull request Jun 22, 2022
2 tasks
Comment on lines -395 to 403
( let
my_toolz = python38.pkgs.buildPythonPackage rec {
my_toolz = python39.pkgs.buildPythonPackage rec {
pname = "toolz";
version = "0.10.0";

src = python38.pkgs.fetchPypi {
src = python39.pkgs.fetchPypi {
inherit pname version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their is a leftover in this expression python38.withPackages (ps: [ps.numpy my_toolz]) Is it intentional ? Now It can be udpated to 3.10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, wasn't intentional. I apparently missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants