Skip to content

Comments

python3Packages.rich: 12.4.1 -> 12.4.4#175437

Closed
arjan-s wants to merge 1 commit intoNixOS:masterfrom
arjan-s:rich-12.4.4
Closed

python3Packages.rich: 12.4.1 -> 12.4.4#175437
arjan-s wants to merge 1 commit intoNixOS:masterfrom
arjan-s:rich-12.4.4

Conversation

@arjan-s
Copy link
Contributor

@arjan-s arjan-s commented May 30, 2022

Description of changes

https://github.com/Textualize/rich/releases
Same as #174350 but targeting master.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@arjan-s arjan-s requested review from FRidh and jonringer as code owners May 30, 2022 07:06
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 30, 2022
@arjan-s arjan-s mentioned this pull request May 30, 2022
Merged
13 tasks
jonringer
jonringer reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of staging is to avoid rebuild churn, which is why rich was merged into staging. Eventually the related change will end up in master after #175150 gets merged in 5-10 days

@arjan-s
Copy link
Contributor Author

arjan-s commented May 30, 2022

@jonringer It is? Oh, then I misunderstood what staging is meant for. I thought it was for the upcoming 22.05 release. If it's going into master as well, I'll just await that.

@ofborg ofborg bot requested a review from risicle May 30, 2022 07:20
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 30, 2022
@arjan-s arjan-s closed this May 30, 2022
@arjan-s arjan-s deleted the rich-12.4.4 branch May 30, 2022 07:25
@jonringer
Copy link
Contributor

jonringer commented May 30, 2022

This can still be merged into staging-next thought, please see #174515 (comment)

@arjan-s
Copy link
Contributor Author

arjan-s commented May 30, 2022

This change is already in staging-next: #174350, so I'll just keep this PR closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@risicle risicle Awaiting requested review from risicle

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arjan-s @jonringer