Either we target staging or you need to ping me or someone else when the rich update is in master or we widen the version constraint.

Either we target staging or you need to ping me or someone else when the rich update is in master or we widen the version constraint.

Oh, I totally missed that the rich PR targeted staging. When I get back to my pc in a few days I'll post a PR for it targeting master, if noone has done it yet. Since it's required from upstream, this PR will have to wait. I'll ping you here once rich is merged.

you can rebase this PR on staging-next as the related staging changes are on there

If you do want to target the staging-next branch:

# finding the common merge base will avoid pinging all CODEOWNERs
common=$(git merge-base origin/master origin/staging-next)
git rebase --onto=$common HEAD~1 # or however many commits you want to pull
git push .. ... --force

then change the base branch in the github PR from master -> staging-next

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

Sorry, I'm new to all this, I just contributed some small changes to master before. Thank you for providing guidance!
If I understand everything right, this PR is now ready.

Sorry, I'm new to all this, I just contributed some small changes to master before. Thank you for providing guidance! If I understand everything right, this PR is now ready.

Yea, looks fine, just waiting on ofborg to go green

Result of nixpkgs-review pr 174515 run on x86_64-linux 1

@jonringer It seems the darwin checks aren't successful, with one skipped and one errored out on building twisted. Is this something I can fix? I don't have darwin nor do I know what the error means...

That needs fixing in twisted. Doing that right now.

Thank you!