Skip to content

Comments

wine: enable parallel build again#173981

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
SFrijters:wine-enable-parallel-build
May 22, 2022
Merged

wine: enable parallel build again#173981
vcunat merged 1 commit intoNixOS:staging-nextfrom
SFrijters:wine-enable-parallel-build

Conversation

@SFrijters
Copy link
Member

Description of changes

Wine can build in parallel again after #172617 ; this ensures that wine will build in parallel again when that fix is propagated to master.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SFrijters SFrijters requested a review from mweinelt May 22, 2022 11:31
@SFrijters SFrijters changed the title wine: Enable parallel build again wine: enable parallel build again May 22, 2022
The issue with dlltool was fixed in 4b0f59a.
@SFrijters SFrijters force-pushed the wine-enable-parallel-build branch from 1f44dce to 30aeecf Compare May 22, 2022 11:31
@mweinelt mweinelt requested a review from vcunat May 22, 2022 11:33
@SFrijters
Copy link
Member Author

@mweinelt With all the wine variations nixpkgs-review says that this updates 47 packages, so it's still quite a number of rebuilds.

47 packages updated:
airwave bottles grapejuice lutris lutris lutris-original pipelight playonlinux q4wine winbox wine wine wine wine wine wine wine wine wine wine wine-wow wine-wow wine-wow wine-wow wine-wow wine-wow wine-wow wine-wow wine-wow wine-wowwayland wine-wowwayland wine64 wine64 wine64 wine64 wine64 wine64 wine64 wine64 wine64 wine64wayland wine64wayland winewayland winewayland winewayland yabridge yabridgectl

@mweinelt
Copy link
Member

That doesn't look like too much. Though wine itself is a big build by itself.

@ofborg ofborg bot requested review from 7c6f434c, avnik, bendlas and jmc-figueira May 22, 2022 11:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 22, 2022
@mweinelt
Copy link
Member

/nix/store/dwqilkb6259a5p9aynya17kqb342n7gn-wine-wow-7.8-staging

lgtm.

@vcunat vcunat merged commit a7d4e41 into NixOS:staging-next May 22, 2022
@SFrijters SFrijters deleted the wine-enable-parallel-build branch May 22, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants