You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
So it looks like nix run would need to change in any case.
what if we instead check if meta.mainProgram is an absolute path and use that if so
I think there's an unwritten rule that meta should not contain store references.
Also the default executable location is normal data that we use in normal expressions, not metadata.
opinions?
Another way to approach this, is to make writeScript return a writeScriptBin package with outPath set to the main executable. Single-file store paths are a forward compatibility mistake anyway, so maybe we should be thinking in this direction? Then nix run could check whether outPath is a store path with subpath, and if so, run that.
It might be preferable for writeScript to return a writeScriptBin x y + "/bin/${x}".
Unfortunately overrideAttrs doesn't seem capable of resetting outPath based on outPath, so that overrideAttrs would keep working as is. We could either add finalDerivationOutputs next to finalPackage, but my preferred option would be to factor out a mkPackage function that would allows us to construct the right behavior without much of the legacy and without the complexity of the finalPackage solution. I'll save that for when we have RFC 92 Dynamic Derivations though.
wegank
added
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
2.status: merge conflict
This PR has merge conflicts with the target branch
labels
Mar 19, 2024
stalebot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Mar 20, 2024
wegank
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.status: merge conflictThis PR has merge conflicts with the target branch2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md10.rebuild-darwin: 0This PR does not cause any packages to rebuild on Darwin.10.rebuild-linux: 1-10This PR causes between 1 and 10 packages to rebuild on Linux.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Broken, because path is missing:
After PR:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes