Skip to content

nixos/xmonad: adjust to reflect v0.17.0 update of xmonad#173623

Merged
sternenseemann merged 2 commits intoNixOS:masterfrom
xaverdh:xmonad-fix-example
May 19, 2022
Merged

nixos/xmonad: adjust to reflect v0.17.0 update of xmonad#173623
sternenseemann merged 2 commits intoNixOS:masterfrom
xaverdh:xmonad-fix-example

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented May 19, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels May 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 19, 2022
@xaverdh xaverdh marked this pull request as ready for review May 19, 2022 14:07
@xaverdh xaverdh mentioned this pull request May 19, 2022
Merged
13 tasks
sternenseemann
sternenseemann reviewed May 19, 2022
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@xaverdh xaverdh force-pushed the xmonad-fix-example branch 2 times, most recently from aee6358 to 640265f Compare May 19, 2022 16:04
@xaverdh xaverdh force-pushed the xmonad-fix-example branch from 640265f to 065085b Compare May 19, 2022 16:11
@cdepillabout cdepillabout added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 19, 2022
@sternenseemann sternenseemann merged commit f181d59 into NixOS:master May 19, 2022
@sternenseemann
Copy link
Member

sternenseemann commented May 19, 2022

Thanks!

@xaverdh xaverdh deleted the xmonad-fix-example branch May 20, 2022 07:45
ivanbrennan
ivanbrennan reviewed May 20, 2022
View reviewed changes
Copy link
Member

@ivanbrennan ivanbrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann left review comments

+1 more reviewer

@ivanbrennan ivanbrennan ivanbrennan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xaverdh @sternenseemann @ivanbrennan @cdepillabout