Skip to content

[haskell-updates] release-haskell.nix: include nixos tests for xmonad#173576

Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:xmonad-tests
May 20, 2022
Merged

[haskell-updates] release-haskell.nix: include nixos tests for xmonad#173576
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:xmonad-tests

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented May 19, 2022

I've recently discovered they were broken by a recent XMonad upgrade,
something we should keep tabs on in the future.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sternenseemann
release-haskell.nix: include nixos tests for xmonad
1e18234 
I've recently discovered they were broken by a recent XMonad upgrade,
something we should keep tabs on in the future.
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 19, 2022
cdepillabout
cdepillabout approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This LGTM.

@sternenseemann
Copy link
Member Author

sternenseemann commented May 19, 2022

@ofborg test xmonad

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 19, 2022
@sternenseemann
Copy link
Member Author

sternenseemann commented May 19, 2022

@Lassulus @xaverdh @ivanbrennan I think it'd be good to update the example text for config in the NixOS module as well, now that we have 0.17.

@xaverdh
Copy link
Contributor

xaverdh commented May 19, 2022

I think #155478 already added instructions for version 0.17.0. We could remove the old ones now, or adjust the order to make the variant for older versions a comment instead?

@sternenseemann
Copy link
Member Author

sternenseemann commented May 19, 2022

I think #155478 already added instructions for version 0.17.0. We could remove the old ones now, or adjust the order to make the variant for older versions a comment instead?

Since we ship 0.16 no longer, the old version can go, I think. We could in theory add an 0.16 attribute for users to choose manually if they don't want to update, not sure if you as a maintainer think that's a good idea.

We probably should also get a release notes entry for 22.05 in, as this update is surely going to bite users.

It'd be great if you or someone familiar with xmonad can send a PR for the doc updates / release notes. I'm not familiar with xmonad and documenting changes is a bit harder than poking a test until it succeeds :)

@xaverdh
Copy link
Contributor

xaverdh commented May 19, 2022

opened #173623

@sternenseemann sternenseemann merged commit 604120a into NixOS:haskell-updates May 20, 2022
@sternenseemann sternenseemann deleted the xmonad-tests branch May 20, 2022 09:48
ivanbrennan
ivanbrennan reviewed May 20, 2022
View reviewed changes
Copy link
Member

@ivanbrennan ivanbrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@maralorn maralorn Awaiting requested review from maralorn

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

+1 more reviewer

@ivanbrennan ivanbrennan ivanbrennan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sternenseemann @xaverdh @cdepillabout @ivanbrennan