Skip to content

haskellPackages.polynomial: Fix build failures for ghc 9#173328

Merged
cdepillabout merged 3 commits intoNixOS:haskell-updatesfrom
neilmayhew:haskell-polynomial
May 18, 2022
Merged

haskellPackages.polynomial: Fix build failures for ghc 9#173328
cdepillabout merged 3 commits intoNixOS:haskell-updatesfrom
neilmayhew:haskell-polynomial

Conversation

@neilmayhew
Copy link
Member

@neilmayhew neilmayhew commented May 16, 2022 •
edited
Loading

Description of changes

haskellPackages.polnomial: Fix build failures for ghc 9

See mokus0/polynomial#20

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 16, 2022
@cdepillabout
Copy link
Member

cdepillabout commented May 17, 2022

@neilmayhew Could you remove the package from the broken list, and run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh --do-commit and push it to this PR as well?

@neilmayhew neilmayhew force-pushed the haskell-polynomial branch from 8b778c0 to 6e028bd Compare May 18, 2022 02:01
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 18, 2022
@cdepillabout
Copy link
Member

cdepillabout commented May 18, 2022

LGTM, thanks!

@cdepillabout cdepillabout merged commit be97d92 into NixOS:haskell-updates May 18, 2022
@cdepillabout cdepillabout mentioned this pull request May 18, 2022
Closed
13 tasks
@neilmayhew neilmayhew deleted the haskell-polynomial branch May 18, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neilmayhew @cdepillabout