haskellPackages.threadscope: Unmark threadscope as broken#173250
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom May 16, 2022
Merged
haskellPackages.threadscope: Unmark threadscope as broken#173250cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
TeofilC
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
|
@ofborg build haskellPackages.threadscope |
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This unmarks threadscope as broken and removes the now unnecessary jailbreak.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes