Skip to content

Comments

python*Packages.azure-core: 1.23.1 -> 1.24.0, fix tests#173179

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:azure-core-bump
May 16, 2022
Merged

python*Packages.azure-core: 1.23.1 -> 1.24.0, fix tests#173179
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:azure-core-bump

Conversation

@K900
Copy link
Contributor

@K900 K900 commented May 15, 2022

Description of changes

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core/CHANGELOG.md#1240-2022-05-06

The version bump didn't actually fix the tests.

Upstream PR for tests fix: Azure/azure-sdk-for-python#24450

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@K900 K900 requested review from FRidh and jonringer as code owners May 15, 2022 18:00
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 15, 2022
fabaff
fabaff reviewed May 15, 2022
View reviewed changes
pkgs/development/python-modules/azure-core/default.nix Outdated
Copy link
Member

@fabaff fabaff May 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/Azure/azure-sdk-for-python/blob/azure-core_1.24.0/sdk/core/azure-core/setup.py#L68

Suggested change
disabled = isPy27;
disabled = pythonOlder "3.6";

Copy link
Contributor Author

@K900 K900 May 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a separate PR?

@vcunat
Copy link
Member

vcunat commented May 15, 2022 •
edited
Loading

Please rebase to the staging-next branch. (requires "removing commits") This fixes build regression on master..staging-next.

@vcunat vcunat changed the base branch from staging to staging-next May 15, 2022 18:35
@vcunat
Copy link
Member

vcunat commented May 15, 2022

/cc PR #172729

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 15, 2022
@vcunat
Copy link
Member

vcunat commented May 16, 2022

@ofborg build python3Packages.azure-core

@vcunat vcunat merged commit fc13119 into NixOS:staging-next May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@K900 @vcunat @fabaff