Revert "lib: init flakes.nix"#173093
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom May 15, 2022
Merged
Conversation
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
I don't see why this has to be in nixpkgs . In the light of recent larger changes to Since we don't have NixOS/rfcs#82, keeping the flakes lib in a stable release would essentially declare something as stable that is not sure to be (or to stay around even). |
7c6f434c
approved these changes
May 15, 2022
tazjin
approved these changes
May 15, 2022
This reverts commit PR NixOS#167947. Flakes aren't standardised and the `lib` namespace shouldn't be polluted with utilities that serve only experimental uses.
adisbladis
force-pushed
the
lib-flakes-nix-revert
branch
from
407a3a8 to
161776e
Compare
This was referenced May 15, 2022
Closed
Member
I sense some frustration here. I know of many reasons why that may be, but not everyone does, and we have to consider that we're in a position of power as maintainers. But alas, maybe I am the one reading too much into this. I'll stop.
Yes please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This reverts PR #167947.
Flakes aren't standardised and the
libnamespace shouldn't be polluted with utilities that serve only experimental uses.If you want this go participate in the RFC, then come back once the interface is no longer experimental.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes