Skip to content

commit: init at 3.2.0#172568

Closed
Cogitri wants to merge 1 commit intoNixOS:masterfrom
Cogitri:commit
Closed

commit: init at 3.2.0#172568
Cogitri wants to merge 1 commit intoNixOS:masterfrom
Cogitri:commit

Conversation

@Cogitri
Copy link
Contributor

@Cogitri Cogitri commented May 11, 2022

Description of changes

Commit is a handy commit message editor for git.
https://github.com/sonnyp/Commit

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 11, 2022
bobby285271
bobby285271 reviewed May 12, 2022
View reviewed changes
Copy link
Member

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes 100+ rebuilds because commit is referenced in pkgs/os-specific/linux/kernel/linux-testing-bcachefs.nix. Not sure if we should give another attribute for this package or resolve the issue on the linux-testing-bcachefs side.

@Cogitri
Copy link
Contributor Author

Cogitri commented May 12, 2022

Thanks for the review, wrapGAppsHook4 gets me every time :D
I don't mind renaming this, do you have suggestions? I don't really want to move this to gnome. since it's not a core application

@jtojnar
Copy link
Member

jtojnar commented Aug 8, 2022

Commit as a package sounds okay to me. Looking at other distros, only AUR appears to ship it and they use the name as well.

So I would say linux_testing_bcachefs needs to be fixed.

cc @Madouura who last touched linux_testing_bcachefs in #171347

@Madouura
Copy link
Contributor

Madouura commented Aug 8, 2022

Commit as a package sounds okay to me. Looking at other distros, only AUR appears to ship it and they use the name as well.

So I would say linux_testing_bcachefs needs to be fixed.

cc @Madouura who last touched linux_testing_bcachefs in #171347

See #179396

@jtojnar jtojnar mentioned this pull request Aug 8, 2022
Merged
13 tasks
@jtojnar jtojnar mentioned this pull request Oct 20, 2022
Closed
31 tasks
jtojnar
jtojnar reviewed Oct 21, 2022
View reviewed changes
pkgs/applications/editors/commit/default.nix
};

patches = [
./always-use-latest.patch
Copy link
Member

@jtojnar jtojnar Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
./always-use-latest.patch
# Do not use absolute path in git config to avoid breakage after GC.
./always-use-latest.patch

jtojnar
jtojnar reviewed Oct 21, 2022
View reviewed changes
pkgs/applications/editors/commit/default.nix
./always-use-latest.patch
];


Copy link
Member

@jtojnar jtojnar Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space?

jtojnar
jtojnar reviewed Oct 21, 2022
View reviewed changes
pkgs/applications/editors/commit/default.nix
'';


dontPatchShebangs = true;
Copy link
Member

@jtojnar jtojnar Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment why this is needed?

@Cogitri Cogitri closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@bobby285271 bobby285271 bobby285271 left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cogitri @jtojnar @Madouura @bobby285271