wdomirror: avoid adding a patch#172466
Merged
Conversation
ghost
mentioned this pull request
13 tasks
A few hours after my previous PR #172441 was merged, one of the upstream contributors responded to my comment that their PR did not adequately address this issue: progandy/wdomirror#7 The PR has not yet merged, but at least now we can reference this commit instead of having a patch in nixpkgs.
ofborg
bot
added
10.rebuild-darwin: 1-10
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
A few hours after my previous PR #172441 was merged, one of the upstream contributors responded to my comment which pointed out that their PR did not adequately address the build failure. That PR has now been updated, and the updated PR does correct it.
The updated PR has not yet merged, but at least now we can reference its commit instead of having a patch in nixpkgs.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes