wdomirror: fix build failure by applying patch from GH #5#172441
Conversation
A recent change to xdg-shell-client-protocol causes a build failure. This was reported upstream as GH #5. User @AlexBMJ posted a two-line fix in that issue, but the developer has not yet responded: progandy/wdomirror#5 (comment)
|
I just tested the resulting binary. This is a really nifty program! I'd hate to see it dropped from nixpkgs. |
ofborg
bot
added
10.rebuild-darwin: 1-10
|
The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92" I am unable to add this build label, so I therefore am issuing this ping. |
|
I don't know anything about the code, but it seems at least somewhat sane. I wanted to ask to fetchpatch this, but I guess that'll be a bit hard like this, so 👍 from me. Result of 1 package built:
|
|
Yeah I know, I felt really guilty not using fetchpatch, but the guy who posted the patch posted it as (a) part of a github comment (not a PR) and (b) as part of a shell script with the patch as a here-doc inside the script which applies the patch. I suppose I could have fetchurl'ed the github comment and then done some sed/awk/whatever to it but I think that would've been just as ugly. So yeah, it's not pretty. But the tool is very cute. |
ghost
deleted the
ghost
mentioned this pull request
|
Ah, see #172466 Shortly after this merged, one of the upstream contributors responded to my request and there is now a PR we can reference with a patch that applies cleanly. So we can drop the patch. |
1 participant
ZHF: #172160
Description of changes
A recent change to xdg-shell-client-protocol causes a build failure.
This was reported upstream as GH #5. User @AlexBMJ posted a two-line
fix in that issue, but the developer has not yet responded:
progandy/wdomirror#5 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes