haskellPackages.mkDerivation: show test outputs as they happen#172365
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom May 21, 2022
Merged
Conversation
Currently, the test output is only printed if the test suite fails. If a test suite gets stuck, however, and is hit with a timeout by Hydra, it can help to have the log available when diagnosing the issue.
sternenseemann
requested review from
cdepillabout,
expipiplus1 and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
|
Sounds like a good idea. Have you tried this on some packages? Won‘t it be too spamy? |
Member
Author
|
Sure, depending on the test suite. Spammy is, however, a trend with the decisions taken in |
Member
Author
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 501+
Member
The experimental CLI hides logs by default, if that's any consolation. Having no logs hurts more than having too much of it, so 👍 . |
Member
|
Okay! I suggest merging this in after next haskell-updates merge. |
Member
Author
|
(Could be bundled with the other set rebuild PR.) |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the test output is only printed if the test suite fails. If a
test suite gets stuck, however, and is hit with a timeout by Hydra, it
can help to have the log available when diagnosing the issue.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes