Skip to content

Comments

Add new dependencies for SILE devel builds#172341

Merged
doronbehar merged 2 commits intoNixOS:masterfrom
alerque:sile-devel
May 10, 2022
Merged

Add new dependencies for SILE devel builds#172341
doronbehar merged 2 commits intoNixOS:masterfrom
alerque:sile-devel

Conversation

@alerque
Copy link
Contributor

@alerque alerque commented May 10, 2022

  • luaPackages: add new packages cldr, fluent, and loadkit
  • luaPackages: update (add cldr, fluent, loadkit; bump cassowary)

These new dependencies (and the cassowary bump) and needed by SILE devel builds. The upstream Nix Flake doesn't work because they are missing, and the stable packaging will need these on the next release.

Running:

$ nix-shell maintainers/scripts/update-luarocks-shell.nix --run maintainers/scripts/update-luarocks-packages

...produces a lot more bumps and changes, many of which look good to me but many others look suspicious (https→http, etc.) so I excluded all the changes except the ones that are directly needed for SILE.

See also upstream issue: sile-typesetter/sile#1388

alerque added 2 commits May 10, 2022 16:57
These are new dependencies for SILE, currently needed by the flake in the upstream repo and will be needed by the stable package in this repo on the next release
These are extracted from:

    nix-shell maintainers/scripts/update-luarocks-shell.nix --run maintainers/scripts/update-luarocks-packages

... but reduced to just the LuaRocks that are *only* SILE dependencies
so I'm confident of bumping them in this context.
@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label May 10, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 10, 2022
@ofborg ofborg bot requested a review from marsam May 10, 2022 14:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 10, 2022
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 172341 run on x86_64-linux 1

1 package marked as broken and skipped:
  • sile
16 packages built:
  • lua51Packages.cassowary
  • lua51Packages.cldr
  • lua51Packages.fluent
  • lua51Packages.loadkit
  • luaPackages.cassowary (lua52Packages.cassowary)
  • luaPackages.cldr (lua52Packages.cldr)
  • luaPackages.fluent (lua52Packages.fluent)
  • luaPackages.loadkit (lua52Packages.loadkit)
  • lua53Packages.cassowary
  • lua53Packages.cldr
  • lua53Packages.fluent
  • lua53Packages.loadkit
  • luajitPackages.cassowary
  • luajitPackages.cldr
  • luajitPackages.fluent
  • luajitPackages.loadkit

@doronbehar
Copy link
Contributor

Why is SILE marked as broken?

@doronbehar doronbehar merged commit 5177069 into NixOS:master May 10, 2022
@doronbehar doronbehar deleted the sile-devel branch May 10, 2022 16:45
@alerque
Copy link
Contributor Author

alerque commented May 10, 2022

I think it was marked as broken on Darwin due to wrapper issues (#171473), but it shouldn't be in general. I don't know what that is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants