Skip to content

Comments

[TEST, DO NOT MERGE] makeBinaryWrapper: remove cc from deps#172257

Closed
ncfavier wants to merge 1 commit intoNixOS:masterfrom
ncfavier:makeBinaryWrapper-test
Closed

[TEST, DO NOT MERGE] makeBinaryWrapper: remove cc from deps#172257
ncfavier wants to merge 1 commit intoNixOS:masterfrom
ncfavier:makeBinaryWrapper-test

Conversation

@ncfavier
Copy link
Member

@ncfavier ncfavier commented May 9, 2022

@ofborg ofborg bot requested review from WilliButz, globin, kalbasit and mmahut May 10, 2022 01:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 10, 2022
@ncfavier ncfavier force-pushed the makeBinaryWrapper-test branch from 55052cf to 7a7413f Compare May 10, 2022 13:01
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 10, 2022
@ncfavier ncfavier force-pushed the makeBinaryWrapper-test branch from 7a7413f to 5830842 Compare May 10, 2022 13:07
@ofborg ofborg bot requested review from WilliButz, globin, kalbasit and mmahut May 10, 2022 13:25
@ncfavier ncfavier changed the title [WIP, DO NOT MERGE] makeBinaryWrapper: remove cc from deps [TEST, DO NOT MERGE] makeBinaryWrapper: remove cc from deps May 10, 2022
@ncfavier
Copy link
Member Author

ncfavier commented May 10, 2022 •
edited
Loading

Ugh, sorry about the review requests. I'm not sure why the bot thinks I'm touching promtail.

@ncfavier ncfavier removed the ofborg-internal-error Ofborg encountered an error label May 10, 2022
@ncfavier ncfavier closed this May 10, 2022
@ncfavier ncfavier mentioned this pull request May 11, 2022
Merged
@ncfavier ncfavier deleted the makeBinaryWrapper-test branch May 19, 2022 22:40
@ncfavier ncfavier mentioned this pull request May 19, 2022
Closed
@cole-h
Copy link
Member

cole-h commented May 20, 2022

In the future, please don't remove the ofborg-internal-error label yourself, so I can investigate the cause and verify it's "just" GitHub being GitHub.

@ncfavier
Copy link
Member Author

ncfavier commented May 20, 2022

OK!

@ncfavier ncfavier mentioned this pull request May 22, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncfavier @cole-h