Skip to content

Comments

autoconf: build offline html documentation#172103

Merged
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
KAction:autoconf-doc
May 9, 2022
Merged

autoconf: build offline html documentation#172103
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
KAction:autoconf-doc

Conversation

@KAction
Copy link
Contributor

@KAction KAction commented May 8, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed May 8, 2022
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 8, 2022

This could potentially cause an infinite recursion and I am not convinced we should draw texinfo into such a core package by default.

@KAction
Copy link
Contributor Author

KAction commented May 8, 2022 •
edited
Loading

I had same concerns, but I built it this morning and it was okay. It rebuilt gcc and a lot of other stuff, hence staging.

Texinfo does not really add much of dependency -- it is written in perl, and autoconf already depends on perl.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 9, 2022
@roberth roberth mentioned this pull request May 9, 2022
Open
2 tasks
@SuperSandro2000 SuperSandro2000 merged commit d954878 into NixOS:staging May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KAction @SuperSandro2000