Skip to content

Comments

cdparanoiaIII: Fix Darwin build after #171046#171997

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
Ericson2314:cdparanoia-fix-darwin
May 8, 2022
Merged

cdparanoiaIII: Fix Darwin build after #171046#171997
vcunat merged 1 commit intoNixOS:staging-nextfrom
Ericson2314:cdparanoia-fix-darwin

Conversation

@Ericson2314
Copy link
Member

Description of changes

I shouldn't have been so hasty rearranging things, and also should have
tested Darwin before merging!

Sorry @vcunat!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

I shouldn't have been so hasty rearranging things, and also should have
tested Darwin before merging!

Sorry @vcunat!
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 7, 2022
@Ericson2314 Ericson2314 requested a review from vcunat May 7, 2022 21:56
@Ericson2314 Ericson2314 mentioned this pull request May 7, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2022
@vcunat vcunat changed the base branch from staging to staging-next May 8, 2022 06:18
@vcunat vcunat merged commit e2d0e57 into NixOS:staging-next May 8, 2022
@Ericson2314 Ericson2314 deleted the cdparanoia-fix-darwin branch May 8, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants