haskellPackages.streamly: fix darwin override#171438
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom May 4, 2022
Merged
haskellPackages.streamly: fix darwin override#171438sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann merged 1 commit intoNixOS:masterfrom
Conversation
Artturin
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
12 tasks
Member
Author
|
@ofborg build haskellPackages.streamly haskellPackages.streamly_0_8_2 |
Member
There was a problem hiding this comment.
I think you can just drop this, since it is unused and just bound to cause the same kind of regression.
Unfortunately, with the way haskellPackages is organized (versioned packages having hydraPlatforms = [ ];) and the jobset implemented (evaluating the package list (not the derivation) for all platforms on a single one), Hydra won't pick the removal of the attribute up for us.
Possibly this override should become a cabal2nix PostProcess rule.
Member
Author
There was a problem hiding this comment.
okay, i noticed that there's already a
streamly = addBuildDepend darwin.apple_sdk.frameworks.Cocoa super.streamly;
on line 33
fixes
```
error: querying available packages failed
caused by: nix-env failed with error: nix-env failed with exit code 1:
error: attribute 'streamly_0_8_1_1' missing
at /nix/store/lw6gp8rrhd7lpi81dk9wr1l09a7za523-source/pkgs/development/haskell-modules/configuration-darwin.nix:259:6:
258| ] ++ (drv.libraryFrameworkDepends or []);
259| }) super.streamly_0_8_1_1;
| ^
260|
```
PR NixOS#160733 didn't catch this it seems.
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
https://github.com/Mic92/nix-index-database/runs/6244309208?check_suite_focus=true
PR #160733 didn't catch this it seems.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes