Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
|
@ofborg build python3.tests.cpython-gdb |
Member
|
@ofborg build pkgsMusl.gdb |
ivan
reviewed
May 4, 2022
ivan
approved these changes
May 4, 2022
Member
ivan
left a comment
ivan
left a comment
There was a problem hiding this comment.
I applied this to NixOS master, booted into a 22.05-pre x86_64 NixOS, used gdb 12.1 a bit and did not see any issues.
Added trivial updater script. Refreshed nix-specific patch with path to debug symbols. Dropped upstreamed patches for gcc-12 support and musl support. Changes: https://www.sourceware.org/gdb/download/ANNOUNCEMENT
Take advantage of the bump and drop the if/null construct for optionalString.
ivan
approved these changes
May 5, 2022
Member
ivan
left a comment
ivan
left a comment
There was a problem hiding this comment.
I did not find issues after building and testing this again on NixOS master.
Artturin
added
the
12.approvals: 2
lsix
approved these changes
May 12, 2022
Member
lsix
left a comment
lsix
left a comment
There was a problem hiding this comment.
Sorry for the delay, this LGTM.
Thanks.
Member
|
This broke on i686-linux due to EDIT: I can't see any patch on their ML or git. |
Contributor
Author
|
Thank you!. Looking. |
13 tasks
Contributor
Author
|
Proposed possible change: #173844 |
Contributor
Author
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
May 21, 2022
A few rare targets don't have clean format strings on 32-bit systems: NixOS#171216 (comment) /build/gdb-12.1/_build/sim/../../sim/cris/sim-if.c:575:28: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'bfd_size_type' {aka 'long long unsigned int'} [-Werror=format=] We pull in patch pending upstream inclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added trivial updater script.
Refreshed nix-specific patch with path to debug symbols.
Dropped upstreamed patches for gcc-12 support and musl support.
Changes: https://www.sourceware.org/gdb/download/ANNOUNCEMENT
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes