Merged
Conversation
Ericson2314
force-pushed
the
cleanup-cdparanoia
branch
from
585d147 to
767b6d5
Compare
10 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Should target staging. Diff LGTM. |
Contributor
|
@ofborg build cdparanoia |
Handle CC the normal way, `unset CC` was from quite old 28b6fb6 during early macOS experiments and no longer needed. Regenerate autoconf stuff unconditionally because it is so old, and unconditional is just simpler. Put conditional patches after unconditional ones as is more idiomatic.
Ericson2314
force-pushed
the
cleanup-cdparanoia
branch
from
767b6d5 to
8a00f0c
Compare
Member
|
The |
Member
Author
|
I'm sorry. I'll go fix that right away. |
Ericson2314
added a commit
to Ericson2314/nixpkgs
that referenced
this pull request
May 7, 2022
I shouldn't have been so hasty rearranging things, and also should have tested Darwin before merging! Sorry @vcunat!
Member
Author
|
OK see #171997 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Handle CC the normal way,
unset CCwas from quite old28b6fb6 during early macOS experiments
and no longer needed.
Regenerate autoconf stuff unconditionally because it is so old, and
unconditional is just simpler.
Put conditional patches after unconditional ones as is more idiomatic.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes