[haskell-updates] haskellPackages: xhtml is not bundled if haddock is disabled#170908
Merged
sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom May 2, 2022
Merged
Conversation
sternenseemann
requested review from
cdepillabout,
expipiplus1 and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
The xhtml library is only built as part of the GHC build process if GHC is disabled. This means that no GHC cross compiler has xhtml bundled, since haddock can't be built if GHC is a cross compiler (see relevant notes in the GHC nix expressions). This means that all packages depending on xhtml would currently fail to build when cross-compiled, as haskellPackages would assume it'd be provided by GHC. This is fixed by this commit. pkgsStatic hits this case, so we test compilation of xhtml for these package sets which will remind us to update the attribute name whenever its version changes.
sternenseemann
force-pushed
the
reflect-xhtml-missing
branch
from
5fd7ed1 to
813f8b5
Compare
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
Member
Author
|
@ofborg build pkgsStatic.haskellPackages.recaptcha |
Contributor
|
I wasn't aware of this problem: I tested some of the packages and it does solve the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xhtml library is only built as part of the GHC build process if GHC
is disabled. This means that no GHC cross compiler has xhtml bundled,
since haddock can't be built if GHC is a cross compiler (see relevant
notes in the GHC nix expressions). This means that all packages
depending on xhtml would currently fail to build when cross-compiled, as
haskellPackages would assume it'd be provided by GHC. This is fixed by
this commit.
See also:
https://gitlab.haskell.org/ghc/ghc/-/blob/0198841877f6f04269d6050892b98b5c3807ce4c/ghc.mk#L463
There seems to be no good way to force GHC to build
xhtmlwhich may be interesting,but I've asked in the ghc IRC channel, maybe it turns up something useful. In any case
this is a very simple fix that requires no rebuilds.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes