Skip to content

llvmPackages: add overrideable withLibunwind#170850

Closed
ghost wants to merge 1 commit intostagingfrom
unknown repository
Closed

llvmPackages: add overrideable withLibunwind#170850
ghost wants to merge 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 29, 2022

Description of changes

This makes it possible to disable bundling libunwind with Clang for out-of-tree platforms.

This shouldn't effect the current evaluation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 29, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@rrbutani rrbutani mentioned this pull request Nov 14, 2022
Merged
92 tasks
@RaitoBezarius
Copy link
Member

RaitoBezarius commented Dec 22, 2022

Can we help get this merged? cc @lovesegfault

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 22, 2022
@RaitoBezarius RaitoBezarius added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 22, 2022
@github-actions github-actions bot added 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: TeX Issues regarding texlive and TeX in general 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` and removed 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nim Nim programing language 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Dec 22, 2022
@github-actions github-actions bot removed 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: stdenv Standard environment 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: printing Drivers, CUPS & Co. labels Dec 22, 2022
@ghost
Copy link
Author

ghost commented Dec 22, 2022 •
edited by ghost
Loading

Sorry about the mass-ping, I rebased against staging and pushed when the PR was based on master.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 22, 2022
llvmPackages: add overrideable withLibunwind
319626a 
This makes it possible to disable bundling libunwind with Clang
for out-of-tree platforms.
@winterqt
Copy link
Member

winterqt commented Dec 22, 2022

Please reopen this -- the mass ping results in people receiving notifications anyways.

@winterqt winterqt closed this Dec 22, 2022
@NixOS NixOS locked and limited conversation to collaborators Dec 22, 2022
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees

No one assigned

Labels

6.topic: exotic Exotic hardware or software platform 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RaitoBezarius @winterqt @rrbutani