Skip to content

nodePackages: use node2nix 1.11.0#170722

Closed
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:nodePackages-node2nix-1.11.0
Closed

nodePackages: use node2nix 1.11.0#170722
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:nodePackages-node2nix-1.11.0

Conversation

@dotlambda
Copy link
Member

Description of changes

I updated node2nix to 1.11.0 but keep around the old node-env.nix (renamed to node-env-1.9.0.nix) for packages that are not in nodePackages but still use its node-env.nix.
This sadly doesn't help with #132456.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from svanderburg April 28, 2022 03:29
@ofborg ofborg bot requested review from Luflosi, midchildan and winterqt April 28, 2022 03:45
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 28, 2022
@dotlambda dotlambda deleted the nodePackages-node2nix-1.11.0 branch January 17, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant