Also it looks like the passthru tests are currently failing.

go test ./... invocation runs unit tests that require loopback networking to bring up stub listeners to test the client behavior. IIUC, networking is entirely disabled in OfBorg runners, hence those unit tests fail.

Also it looks like the passthru tests are currently failing.

go test ./... invocation runs unit tests that require loopback networking to bring up stub listeners to test the client behavior. IIUC, networking is entirely disabled in OfBorg runners, hence those unit tests fail.

Perhaps you should disable those specific tests? I don't think merging failing tests is a good idea, it could block the package from getting stable NixOS branches.

I don't know why, yet, but the tests experience a network failure on the ofborg builders... I don't have much time to look into why that is this weekend, so... For the moment, would you mind disabling the tests (or even just those specific tests, if possible...)? Feel free to add a TODO(cole-h): figure out why tests fail loopback networking in ofborg comment above it, if you so desire. (FWIW: It builds just fine on my local machine, no networking issues whatsoever.)

I don't know why, yet, but the tests experience a network failure on the ofborg builders... I don't have much time to look into why that is this weekend, so... For the moment, would you mind disabling the tests (or even just those specific tests, if possible...)? Feel free to add a TODO(cole-h): figure out why tests fail loopback networking in ofborg comment above it, if you so desire. (FWIW: It builds just fine on my local machine, no networking issues whatsoever.)

Alright. I was gonna skip these tests but then I hit a bug in go-modules/generic/default.nix w.r.t how $checkFlags is passed to buildGoDir helper, which doesn't expect more than 2 parameters but a checkFlags list may get expanded to a space separated string, which will get interpreted as multiple arguments. Will send a PR for that as well.

diff --git a/pkgs/development/go-modules/generic/default.nix b/pkgs/development/go-modules/generic/default.nix
index 502a981596e..dd829e8dbd6 100644
--- a/pkgs/development/go-modules/generic/default.nix
+++ b/pkgs/development/go-modules/generic/default.nix
@@ -244,7 +244,7 @@ let
       runHook preCheck
░
       for pkg in $(getGoDirs test); do
-        buildGoDir test $checkFlags "$pkg"
+        buildGoDir "test $checkFlags" "$pkg"
       done
░
       runHook postCheck