emacs: Build from git instead of tarball to fix native compilation#170467
Merged
adisbladis merged 1 commit intoNixOS:masterfrom Apr 26, 2022
Merged
emacs: Build from git instead of tarball to fix native compilation#170467adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis merged 1 commit intoNixOS:masterfrom
Conversation
collares
reviewed
Apr 26, 2022
Quoting @collares from NixOS#170426: > The difference between the two versions is that one is built from the > tarball, while the other is built from Git. The tarball includes > byte-compiled (.elc) files but not native-compiled (.eln) > files. The build notices the .elc files and does not rebuild them, > but native-compilation is a side-effect of byte-compilation and so > the .eln files aren't built either.
adisbladis
force-pushed
the
emacs-from-git
branch
from
485b431 to
54e7957
Compare
collares
approved these changes
Apr 26, 2022
Member
There was a problem hiding this comment.
Thanks for the fix!
(I find it interesting that both https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-28.1.tar.gz and https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-emacs-28.1.tar.gz exist and extract to the same thing!)
ofborg
bot
added
11.by: package-maintainer
Contributor
|
Seem to be late for the party. Just compiled Thanks. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Quoting @collares from #170426:
Closes #170426
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes