Skip to content

darwin.network_cmds: switch openssl to libressl#170454

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
willcohen:network_cmds
Apr 27, 2022
Merged

darwin.network_cmds: switch openssl to libressl#170454
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
willcohen:network_cmds

Conversation

@willcohen
Copy link
Contributor

@willcohen willcohen commented Apr 26, 2022 •
edited
Loading

Description of changes

To fix #168977.

Things done

Switch use of openssl to libressl, due to #150880 and per suggestion from #168977 (comment).

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 26, 2022
@willcohen willcohen mentioned this pull request Apr 26, 2022
Closed
@willcohen
Copy link
Contributor Author

willcohen commented Apr 26, 2022

Result of nixpkgs-review pr 170454 run on x86_64-darwin 1

17 packages built:
  • acme-sh
  • cvsq
  • gitolite
  • hyprspace
  • iodine
  • nettools
  • openconnect
  • openconnect_openssl
  • openconnect_unstable
  • swtpm
  • testssl
  • unixtools.arp
  • unixtools.ifconfig
  • unixtools.netstat
  • unixtools.ping
  • unixtools.route
  • vpnc-scripts

@ofborg ofborg bot requested a review from matthewbauer April 26, 2022 18:00
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 26, 2022
This was referenced Apr 26, 2022
Closed
Merged
@veprbl
Copy link
Member

veprbl commented Apr 26, 2022

Result of nixpkgs-review pr 170454 run on x86_64-darwin 1

37 packages marked as broken and skipped:
  • connman_dmenu
  • dhcp
  • fgallery
  • frr
  • fusionInventory
  • gnome.nautilus-python
  • gscan2pdf
  • ike
  • jpsxdec
  • kaffeine
  • libsForQt5.alkimia
  • libsForQt512.alkimia
  • libsForQt514.alkimia
  • libsForQt515.alkimia
  • lightly-qt
  • miredo
  • networkmanager_dmenu
  • ntopng
  • perl532Packages.ImageSane
  • perl534Packages.ImageSane
  • plasma5Packages.alkimia
  • prometheus-snmp-exporter
  • python310Packages.meshtastic
  • python310Packages.paperwork-backend
  • python310Packages.paperwork-shell
  • python310Packages.python-ethtool
  • python310Packages.sane
  • python39Packages.meshtastic
  • python39Packages.paperwork-backend
  • python39Packages.paperwork-shell
  • python39Packages.python-ethtool
  • python39Packages.sane
  • ssm-agent
  • strongswanNM
  • sublime-music
  • vimix-gtk-themes
  • whitesur-gtk-theme
11 packages built:
  • acme-sh
  • cvsq
  • darwin.iproute2mac
  • darwin.network_cmds
  • gitolite
  • hyprspace
  • iodine
  • openconnect
  • openconnect_openssl
  • openconnect_unstable
  • vpnc-scripts

@willcohen
Copy link
Contributor Author

willcohen commented Apr 26, 2022

Fascinating -- are you on Monterey too?

@veprbl
Copy link
Member

veprbl commented Apr 26, 2022

No, on 10.14

@reckenrode
Copy link
Contributor

reckenrode commented Apr 26, 2022 •
edited
Loading

A lot of those look related to SANE. I don’t know if the derivations are individually marked broken, but sane-backends doesn’t build currently on Darwin, so they wouldn’t build regardless. I’ve opened PR #169510 to fix that.

@willcohen
Copy link
Contributor Author

willcohen commented Apr 27, 2022

If the breakages we're seeing (which for whatever reason aren't reproducing for me) are unrelated to this PR, is there anything that we still need to do on this? It'd be nice to get this unbroken somewhat soon. Broken network_cmds breaks libtpms which breaks swtpm which breaks TPM on qemu, which breaks booting Windows 11 on Mac.

@SuperSandro2000 SuperSandro2000 merged commit 941c24d into NixOS:master Apr 27, 2022
@willcohen
Copy link
Contributor Author

willcohen commented Apr 27, 2022

Thanks!

@willcohen willcohen deleted the network_cmds branch April 27, 2022 15:29
@WolfangAukang WolfangAukang mentioned this pull request May 6, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

network_cmds fails to build on unstable and master

4 participants

@willcohen @veprbl @reckenrode @SuperSandro2000