rmfuse: Fix fallout from #139480#170193
Merged
adisbladis merged 1 commit intoNixOS:masterfrom Apr 25, 2022
Merged
Conversation
This reverts commit 4f62471.
adisbladis
force-pushed
the
rmfuse-fix-139480
branch
2 times, most recently
from
1573dc7 to
9af334d
Compare
Member
adisbladis
force-pushed
the
rmfuse-fix-139480
branch
from
58aeacf to
49d7964
Compare
Member
Author
|
@bobby285271 I tried that at some point but ofborg still fails eval for some unknown reason... |
Member
Author
|
I really don't like the fact that ofborg is responsible for evals instead of Github Actions which should have far lower latency. |
Contributor
|
ofborg evals the base branch first |
adisbladis
force-pushed
the
rmfuse-fix-139480
branch
from
49d7964 to
3c805b7
Compare
Member
Author
|
@zowoq That would explain it.. This is some terrible UX at play here. |
adisbladis
force-pushed
the
rmfuse-fix-139480
branch
from
3c805b7 to
9af334d
Compare
Member
Author
|
I'm just going to go ahead and merge the revert for now no matter what ofborg thinks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I used the wrong incantation when testing this PR, resulting in not actually testing it :/
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes