haskellPackages.sensei: mark unbroken, override#170027
haskellPackages.sensei: mark unbroken, override#170027cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
Conversation
hypevhs
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
I think this should probably be testSystemDepends, since git is needed when running tests, right? (If git also needs to be available at runtime, then you'll likely need something like wrapProgram. Or just rely on users having git in their PATH.)
There was a problem hiding this comment.
git is required on the PATH both when running the tests and the binary. It will crash otherwise. I agree though, I'll move it to just a test dependency, then rely on users at runtime.
I believe testToolDepends would work better here since we're not linking with git, we just need it on the PATH.
There was a problem hiding this comment.
I believe testToolDepends would work better here since we're not linking with git, we just need it on the PATH.
Ah, good point, I think you're correct about this.
|
Also, please feel free to add yourself as a maintainer for this package in |
Sensei had an issue on NixOS relating to tmpfs, and 0.6.2 fixes that. But it still needs an override because it (the binary *and* the tests) require the git binary and latest hspec.
hypevhs
force-pushed
the
haskell-updates-sensei
branch
2 times, most recently
from
3a9a4fe to
2583067
Compare
hypevhs
force-pushed
the
haskell-updates-sensei
branch
from
2583067 to
a36d453
Compare
2 participants
Description of changes
Sensei had an issue on NixOS relating to tmpfs, and 0.6.2 fixes that.
But it still needs an override because it (the binary and the tests)
require the git binary and latest hspec.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes