Skip to content

naproche: fix build with GHC 9#169400

Merged
cdepillabout merged 2 commits intoNixOS:masterfrom
jvanbruegge:fix-naproche
Apr 20, 2022
Merged

naproche: fix build with GHC 9#169400
cdepillabout merged 2 commits intoNixOS:masterfrom
jvanbruegge:fix-naproche

Conversation

@jvanbruegge
Copy link
Contributor

Description of changes

Currently this prevents users from installing isabelle

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2022
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fixes naproche and Isabelle builds.

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, given there is no release tag, the version should be changed to YYYY-MM-DD.

This fixes the build with GHC 9
@jvanbruegge
Copy link
Contributor Author

Done

@cdepillabout
Copy link
Member

cdepillabout commented Apr 20, 2022

A couple points:

  • In general, Haskell packages (even packages with only an exectuable) should be uploaded to Hackage. That way, Haskellers can get them through their normal channels (like cabal, stack, Nixpkgs, haskell.nix, other Linux distros, etc). Uploading your Haskell programs to Hackage means that you mostly don't have to do any work to keep it up-to-date in Nixpkgs. It gets automatically updated to the latest release on Hackage. If you're not the maintainer, I'd highly recommend creating an issue upstream urging the maintainer to release to Hackage. (Although it appears that it wouldn't have helped in this case, since you're using an un-released version. But in general it still holds true.)

  • Is there somewhere I need to register naproche so it will get caught here in the next round of updates

    You can add naproche to the list in

    inherit (pkgsPlatforms)
    agda
    arion
    bench
    bustle
    blucontrol

    This makes sure that naproche will appear in the build reports for the haskell-updates PRs. Here's an example build report:

    haskellPackages: update stackage and hackage #168049 (comment)

  • It is generally easier for us to have Haskell-related PRs targetting the haskell-updates branch instead of master (although this shouldn't prevent this PR from getting merged in as-is). In the future, you can also feel free to ping @-NixOS/haskell to get your Haskell-related PRs reviewed/merged.

This will ensure maintainers get notified on haskell updates
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 20, 2022
@jvanbruegge
Copy link
Contributor Author

Thanks.

  • Yeah, I am not the maintainer, and I don't think they will upload it to hackage any time soon. I just need it for isabelle
  • Thanks, added it now there
  • ok, i will target haskell-updates in the future

@cdepillabout
Copy link
Member

Thanks for the quick response!

@cdepillabout cdepillabout merged commit 87da0aa into NixOS:master Apr 20, 2022
@jvanbruegge jvanbruegge deleted the fix-naproche branch April 20, 2022 08:00
@jvanbruegge
Copy link
Contributor Author

Thanks for the quick reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants