qtmultimedia: restrict libpulseaudio to linux#169336
Merged
vcunat merged 1 commit intoNixOS:masterfrom Apr 20, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: qt/kde
Member
Author
|
I did spend a bit of time making libpulseaudio build on darwin. The results are on a branch: https://github.com/NixOS/nixpkgs/compare/master...thefloweringash:libpulseaudio-darwin?expand=1 I haven't done the work required to make sure these changes are sound or send them upstream, but hopefully they're a useful starting point for someone interested in making libpulseaudio build on darwin. |
ofborg
bot
added
10.rebuild-darwin: 101-500
ttuegel
reviewed
Apr 19, 2022
thefloweringash
force-pushed
the
qtmultimedia-no-pulse
branch
from
3c1d7ca to
5fe6118
Compare
ofborg
bot
added
10.rebuild-linux: 0
libpulseaudio doesn't currently build on darwin after a recent upgrade (NixOS#160097). When looking closely at the darwin build, it appeared that it wasn't being used at all. ❯ nix log $(nix-build --no-out-link channel:nixpkgs-unstable --argstr system x86_64-darwin -A qt512.qtmultimedia) | grep PulseAudio Checking for PulseAudio >= 0.9.10... no PulseAudio ............................. no ❯ nix log $(nix-build --no-out-link channel:nixpkgs-unstable --argstr system x86_64-darwin -A qt514.qtmultimedia) | grep PulseAudio Checking for PulseAudio >= 0.9.10... no PulseAudio ............................. no ❯ nix log $(nix-build --no-out-link channel:nixpkgs-unstable --argstr system x86_64-darwin -A qt515.qtmultimedia) | grep PulseAudio Checking for PulseAudio >= 0.9.10... no PulseAudio ............................. no
Artturin
force-pushed
the
qtmultimedia-no-pulse
branch
from
5fe6118 to
85020dc
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpulseaudio doesn't currently build on darwin after a recent
upgrade (#160097). When looking closely at the darwin build, it
appeared that it wasn't being used at all.
Description of changes
So far as I can tell, the requirement for pulseaudio support in qtmultimedia is the pkg-config expression
libpulse >= 0.9.10 libpulse-mainloop-glib, which requires pulseaudio to be configured with glib on darwin. Once libpulseaudio is working again, it's a fairly straightforward change to make. I don't know if there are wider consequences to using glib though.I must confess I'm tying to keep nixpkgs-unstable unblocked more than I'm trying to fix pulseaudio.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes