Skip to content

tpm2-abrmd: 2.3.3 -> 2.4.1 & fix build#169085

Merged
vcunat merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/tpm2-abrmd
Apr 18, 2022
Merged

tpm2-abrmd: 2.3.3 -> 2.4.1 & fix build#169085
vcunat merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/tpm2-abrmd

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Apr 17, 2022 •
edited
Loading

Description of changes

Follow-up to #167940

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

ajs124 added 2 commits April 17, 2022 18:29
@ajs124
tpm2-abrmd: 2.3.3 -> 2.4.1
9a724bd
@ajs124
tpm2-tss: fix version detection
779cca1 
without this, the version field in the .pc files is empty
leading to tpm2-abrmd failing to build
@ajs124 ajs124 marked this pull request as ready for review April 17, 2022 18:04
@ajs124 ajs124 mentioned this pull request Apr 17, 2022
Merged
13 tasks
@ajs124 ajs124 requested a review from vcunat April 17, 2022 18:05
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 17, 2022
@vcunat
Copy link
Member

vcunat commented Apr 17, 2022

The commit breaking this reached nixpkgs master already.

@ajs124
Copy link
Member Author

ajs124 commented Apr 17, 2022

Oh no. So should we also go to master with this? It's >5k rebuilds...

@vcunat vcunat merged commit 4772f65 into NixOS:staging Apr 18, 2022
@ajs124 ajs124 deleted the upd/tpm2-abrmd branch April 18, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajs124 @vcunat