Skip to content

cjdns: don't set -Wno-error=stringop-overread with gcc<11#168997

Merged
Artturin merged 1 commit intoNixOS:staging-nextfrom
mweinelt:cjdns-aarch64
Apr 17, 2022
Merged

cjdns: don't set -Wno-error=stringop-overread with gcc<11#168997
Artturin merged 1 commit intoNixOS:staging-nextfrom
mweinelt:cjdns-aarch64

Conversation

@mweinelt
Copy link
Member

The build would error out on aarch64-linux with

cc1: error: '-Werror=stringop-overread': no option -Wstringop-overread

Description of changes

Not sure if this is the correct way to handle this problem.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The build would error out on aarch64-linux with

> cc1: error: '-Werror=stringop-overread': no option -Wstringop-overread
@mweinelt mweinelt requested a review from fabianhjr April 17, 2022 00:58
@ofborg ofborg bot requested a review from a user April 17, 2022 01:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 17, 2022
@Artturin Artturin merged commit 503a904 into NixOS:staging-next Apr 17, 2022
@mweinelt mweinelt deleted the cjdns-aarch64 branch April 17, 2022 01:42
admin-turris pushed a commit to turris-cz/os-build that referenced this pull request Nov 3, 2023
…version 11

Added condition to remove -Wno_overread warning if toolchain
is lower than version 11, based on
recommendation (NixOS/nixpkgs#168997)
Added two patches from OpenWrt feed.
python-3.10-patch (1df5290b92625823bb9725a5406383116463f3ac)
invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c)
admin-turris pushed a commit to turris-cz/os-build that referenced this pull request Nov 27, 2023
…version 11

Added condition to remove -Wno_overread warning if toolchain
is lower than version 11, based on
recommendation (NixOS/nixpkgs#168997)
Added two patches from openwrt stream.
patch3.10 (1df5290b92625823bb9725a5406383116463f3ac)
invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c)
In previous patch there was error with empty intcmp.
This commit fix error in in 26c38a1
Rename TARGET_CCFLAGS to EXTRA_TARGET_CFLAGS, because TARGET_CCFLAGS is for C++ stuff.
admin-turris pushed a commit to turris-cz/os-build that referenced this pull request Jul 3, 2024
Added condition to remove -Wno_overread warning if toolchain
is lower than version 11, based on
recommendation (NixOS/nixpkgs#168997)
Added two patches from openwrt stream.
patch3.10 (1df5290b92625823bb9725a5406383116463f3ac)
invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c)
In previous patch there was error with empty intcmp.
This commit fix error in in 26c38a1
Rename TARGET_CCFLAGS to EXTRA_TARGET_CFLAGS, because TARGET_CCFLAGS is for C++ stuff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants