Skip to content

tvheadend: add tvheadend-latest alonside tvheadend#168620

Closed
melias122 wants to merge 2 commits intoNixOS:masterfrom
melias122:tvheadend-master-package
Closed

tvheadend: add tvheadend-latest alonside tvheadend#168620
melias122 wants to merge 2 commits intoNixOS:masterfrom
melias122:tvheadend-master-package

Conversation

@melias122
Copy link
Contributor

@melias122 melias122 commented Apr 14, 2022 •
edited
Loading

Description of changes

This commit is inspired by/copy of matomo/default.nix. It also updates
dtv-scan-tables to latest commit.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@melias122
tvheadend-latest: init at 9a51cea492e4a5579ca3ddf9233fecfa419de078
5c50c81 
This commit allows using tvheadend from master branch, which many of
us are using as default tvheadend version. This is not "unstable"
version, but it is not tagged.
@melias122
tvheadend: update dtv-scan-tables 2020-05-18 -> 2022-03-14
50a4ddf
@melias122 melias122 force-pushed the tvheadend-master-package branch from c2a086c to 50a4ddf Compare April 20, 2022 08:41
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2022
@melias122 melias122 requested review from danielfullmer and dotlambda and removed request for danielfullmer and dotlambda April 20, 2022 09:33
@nixos-discourse
Copy link

nixos-discourse commented Jul 5, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/965

SuperSandro2000
SuperSandro2000 reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit should also be adjusted to not contain the commit hash.

Also why do we need this? If the last release version is a long time ago we should rather update the current version instead of introducing a new package.

pkgs/servers/tvheadend/default.nix
rev = "e3138a506a064f6dfd0639d69f383e8e576609da";
sha256 = "19ac9ds3rfc2xrqcywsbd1iwcpv7vmql7gp01iikxkzcgm2g2b6w";
tvheadend-latest = {
version = "master-9a51cea";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format should be unstable-XXXX-XX-XX where XXXX-XXXX is the date of the commit.

@melias122
Copy link
Contributor Author

melias122 commented Jul 6, 2022

Also why do we need this? If the last release version is a long time ago we should rather update the current version instead of introducing a new package.

Updating to latest master (aka v4.3) will break configs of most people using v4.2. Thats why I went with new package. If there is any other way to keep both versions or v4.3 only in unstable channel that would also work, but I am not expert on nix packages, so would need some help.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@emilazy emilazy mentioned this pull request Aug 4, 2024
Closed
13 tasks
@emilazy emilazy mentioned this pull request Aug 24, 2024
Merged
13 tasks
@melias122 melias122 closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@melias122 @nixos-discourse @SuperSandro2000 @wegank