pythonPackages.levenshtein: fix 0.18.1 build#168547
Closed
yuuyins wants to merge 5 commits intoNixOS:masterfrom
Closed
pythonPackages.levenshtein: fix 0.18.1 build#168547yuuyins wants to merge 5 commits intoNixOS:masterfrom
yuuyins wants to merge 5 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
yuuyins
force-pushed
the
levenshtein
branch
3 times, most recently
from
18c19b1 to
5c80c42
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
Co-authored-by: Martin Weinelt <[email protected]>
Contributor
Author
|
#158881 won't build and is blocking |
dotlambda
requested changes
Apr 14, 2022
| description = "C-API of RapidFuzz, which can be used to extend RapidFuzz from separate packages"; | ||
| homepage = "https://github.com/maxbachmann/rapidfuzz_capi"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ dotlambda ]; |
Contributor
Author
There was a problem hiding this comment.
@dotlambda ? 28b65c3#diff-7051ba4a27a1aa6bb264875507a22237c6aaf3566a13335c6c96f76593be5314
i'm probably going to remove this file and wait for your pr to get merged
Member
There was a problem hiding this comment.
Oops, I meant to put this on the respective line in rapidfuzz-cpp
| sha256 = "127mwjbyp2nfj846bxb3aajmhsgzfx4wfvizpnwb30yv2fcrpy7l"; | ||
| }; | ||
|
|
||
| pythonImportsCheck = [ "rapidfuzz_capi" ]; |
Member
There was a problem hiding this comment.
This also needs pytestCheckHook in checkInputs or a checkPhase.
Comment on lines
+61
to
+63
| cmakeFlags = [ | ||
| "-DCMAKE_MODULE_PATH=${python.pkgs.scikit-build}/${python.sitePackages}/skbuild/resources/cmake" | ||
| ]; |
Member
There was a problem hiding this comment.
Suggested change
| cmakeFlags = [ | |
| "-DCMAKE_MODULE_PATH=${python.pkgs.scikit-build}/${python.sitePackages}/skbuild/resources/cmake" | |
| ]; |
|
|
||
| nativeBuildInputs = [ | ||
| cmake | ||
| ninja |
Member
There was a problem hiding this comment.
can be patched out or just left out if you use format = "setuptools"
| homepage = "https://github.com/maxbachmann/Levenshtein"; | ||
| license = licenses.gpl2Plus; | ||
| maintainers = with maintainers; [ fab ]; | ||
| platforms = platforms.all; |
Member
There was a problem hiding this comment.
Suggested change
| platforms = platforms.all; |
that's automatic for Python packages
Member
|
already part of python-updates. Feel free to add yourself as maintainer there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
won't build after 7ed8ac0
cc @mweinelt @fabaff
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes