haskell.compiler.ghcjs: fix build with aeson 2.0 #168195
Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom Apr 12, 2022
Merged
haskell.compiler.ghcjs: fix build with aeson 2.0 #168195sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
Conversation
sternenseemann
requested review from
cdepillabout,
expipiplus1 and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
This comment was marked as outdated.
This comment was marked as outdated.
sternenseemann
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
By telling Hydra where to look explicitly, it can be instrumented to build the boot ghcjs which is only about 300MB. This saves at least some time compiling for users and will also provide some eval CI automatically.
sternenseemann
force-pushed
the
ghcjs-fix-build
branch
from
f52fcd3 to
7ad0327
Compare
Member
Author
|
@ofborg build haskell.compiler.ghcjs.bootGhcjs |
Member
|
cc @dfordivam |
dfordivam
approved these changes
Apr 12, 2022
Contributor
dfordivam
left a comment
dfordivam
left a comment
There was a problem hiding this comment.
I believe the webdriver changes breaks the compilation with aeson <2.0. But for nixpkgs that is not an issue (I think), so approving.
Member
Author
Indeed, that is why I've only applied it to the bootstrap |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes