Skip to content

keyutils: inline patch to improve reproducibility#167346

Merged
Artturin merged 1 commit intoNixOS:stagingfrom
Artturin:keyutilsrepro
Apr 6, 2022
Merged

keyutils: inline patch to improve reproducibility#167346
Artturin merged 1 commit intoNixOS:stagingfrom
Artturin:keyutilsrepro

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Apr 5, 2022

switch to using SOURCE_DATE_EPOCH instead of BUILDDATE

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Apr 5, 2022
Merged
@vcunat
Copy link
Member

vcunat commented Apr 5, 2022

I suspect this is quite a significant rebuild.

@Artturin
Copy link
Member Author

Artturin commented Apr 5, 2022

29062 x86_64-linux

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 5, 2022
@vcunat
Copy link
Member

vcunat commented Apr 5, 2022 •
edited
Loading

I'm not sure about this. The three installer tests build now without this PR, after adding kmod.dev. EDIT: I mean, at least not to be merged immediately to staging-next, due to the rebuild amount.

@Artturin
keyutils: inline patch to improve reproducibility
e69fd09 
switch to using SOURCE_DATE_EPOCH instead of BUILDDATE
@Artturin Artturin changed the base branch from staging-next to staging April 5, 2022 17:40
@Artturin Artturin merged commit c2ad6eb into NixOS:staging Apr 6, 2022
@Artturin Artturin deleted the keyutilsrepro branch April 6, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Artturin @vcunat