.github/workflows/check-commits.yml: check for the existence of fixup…#167312
.github/workflows/check-commits.yml: check for the existence of fixup…#167312Artturin wants to merge 2 commits intoNixOS:masterfrom
Conversation
… commits oftentimes people forget to either fixup the fixup! commits or forget to squash merge this should prevent that from happening
github-actions
bot
added
the
6.topic: policy discussion
|
Does this really happen that often that we need an action? Can you show some data from the git history? |
Artturin
force-pushed
the
checkfixupcommits
branch
from
58c8fc9 to
3e75ae8
Compare
|
People probably won't like getting a ❌ on PRs that could be squashed. |
|
theres notice, warning, and error messages i don't know if warnings show up as a red X |
That is for the message, I'm talking about the check status. AFAIK is has to be either green or red. |
ofborg
bot
added
10.rebuild-darwin: 0
|
Looks like you're trying to test this here, it won't actually work unless it is on master. As it doesn't need any of the |
|
There are other actions and apps on the marketplace that we could for this (and other commit lint/style checks) which may be better than writing and needing to maintain our own. Adding it to |
2 participants
… commits
oftentimes people forget to either fixup the fixup! commits or forget to
squash merge
this should prevent that from happening
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes