haskellPackages.mkDerivation: fix pkg-config cross#166781
Merged
rnhmjoj merged 1 commit intoNixOS:haskell-updatesfrom Apr 1, 2022
Merged
haskellPackages.mkDerivation: fix pkg-config cross#166781rnhmjoj merged 1 commit intoNixOS:haskell-updatesfrom
rnhmjoj merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
When cross compiling the pkg-config binary is prefixed and cabal needs to be made aware of this. Note: the `--with-pkg-config` flag can't be added unconditionally because if the package doesn't need pkg-config (thus pkg-config is not in the PATH) cabal consider this a hard failure.
rnhmjoj
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
rnhmjoj
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Will ofborg build anything of these for us? @ofborg build pkgsStatic.haskellPackages.alsa-core pkgsStatic.haskellPackages.libffi pkgsStatic.haskellPackages.Xauth |
Contributor
Author
|
@cdepillabout Looks like it did, at least for x86_64-linux. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
sternenseemann
approved these changes
Apr 1, 2022
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When cross compiling the pkg-config binary is prefixed and cabal
needs to be made aware of this.
Note: the
--with-pkg-configflag can't be added unconditionallybecause if the package doesn't need pkg-config (thus pkg-config
is not in the PATH) cabal consider this a hard failure.
Things done
libraryPkgconfigDepends:pkgsStatic.haskellPackages.alsa-corepkgsStatic.haskellPackages.libffipkgsStatic.haskellPackages.Xauth