Skip to content

[21.11] zlib: 1.2.11 -> 1.2.12#166610

Merged
mweinelt merged 2 commits intoNixOS:release-21.11from
mweinelt:21.11-zlib
Mar 31, 2022
Merged

[21.11] zlib: 1.2.11 -> 1.2.12#166610
mweinelt merged 2 commits intoNixOS:release-21.11from
mweinelt:21.11-zlib

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 31, 2022 •
edited
Loading

Description of changes

Backport #165642 #166451
Supersedes #165951

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

twz123 and others added 2 commits March 31, 2022 20:45
@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 31, 2022
@mweinelt mweinelt requested a review from jonringer as a code owner March 31, 2022 18:57
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 31, 2022
@mweinelt mweinelt merged commit 7e2165f into NixOS:release-21.11 Mar 31, 2022
@mweinelt mweinelt deleted the 21.11-zlib branch March 31, 2022 21:36
@tnias
Copy link
Contributor

tnias commented Apr 1, 2022

Closes #166708?

This was referenced Apr 1, 2022
Closed
Closed
vcunat added a commit to vcunat/nixpkgs that referenced this pull request Apr 2, 2022
@vcunat
perlPackages.CompressRawZlib: doCheck = false; for now
1d24330 
Failure triggered by the (security) zlib update in PR NixOS#166610.
@vcunat vcunat mentioned this pull request Apr 2, 2022
Merged
13 tasks
@thiagokokada
Copy link
Contributor

thiagokokada commented Apr 2, 2022 •
edited
Loading

I can't confirm it yet (I am without access with a Linux machine at the moment), however this will probably break all packages depending on GraalVM and using the zip module in Java. This is a known bug: oracle/graal#4439 (yeah, it is closed because the original bug report is for the removal of 1.2.11 version from zlib website, but the issue itself is not fixed and I am trying to raise this).

Given this issue and the one with Perl linked above, wouldn't it better that we just backport the security patches (#165951) instead for release-21.11 instead? I fear that this may break more things than expected.

Of course, on master we should continue with the 1.2.12 bump instead.

yayayayaka pushed a commit to yayayayaka/nixpkgs that referenced this pull request May 1, 2022
@vcunat @yayayayaka
perlPackages.CompressRawZlib: doCheck = false; for now
a6187da 
Failure triggered by the (security) zlib update in PR NixOS#166610.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jul 13, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
46a3ae5 
Failure triggered by the (security) zlib update in PR NixOS#166610.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jul 21, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
249531a 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Aug 4, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
abd6c1e 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 5, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
d7d8c41 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 20, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
0b4b128 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Nov 17, 2023
@vcunat @bacchanalia
perlPackages.CompressRawZlib: doCheck = false; for now
7e09422 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 21, 2023
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
09124fd 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jan 13, 2024
@vcunat @jsoo1
perlPackages.CompressRawZlib: doCheck = false; for now
8df2082 
Failure triggered by the (security) zlib update in PR NixOS#166610.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Feb 23, 2024
@vcunat @tm-drtina
perlPackages.CompressRawZlib: doCheck = false; for now
232d4fb 
Failure triggered by the (security) zlib update in PR NixOS#166610.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@grahamc grahamc Awaiting requested review from grahamc

@vcunat vcunat Awaiting requested review from vcunat

@alyssais alyssais Awaiting requested review from alyssais

1 more reviewer

@wamserma wamserma wamserma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mweinelt @tnias @thiagokokada @wamserma @twz123