Skip to content

powerdns: fix 32-bit builds against glibc#166534

Merged
symphorien merged 2 commits intoNixOS:staging-nextfrom
vcunat:p/powerdns-32bit
Apr 5, 2022
Merged

powerdns: fix 32-bit builds against glibc#166534
symphorien merged 2 commits intoNixOS:staging-nextfrom
vcunat:p/powerdns-32bit

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Mar 31, 2022

Things done
  • Built on platform(s)
    • x86_64-linux
    • i686-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Mar 31, 2022

This is for staging-next because (surprisingly) the support for 64-bit time_t on 32-bit platforms was only added in glibc 2.34 which still isn't in nixpkgs master.

@vcunat vcunat mentioned this pull request Mar 31, 2022
Merged
13 tasks
@vcunat
Copy link
Member Author

vcunat commented Mar 31, 2022

The announcement says

full support requires a minimum kernel version of 5.1

but that's hopefully satisfied in most of the (32-bit) cases.

@NickCao
Copy link
Member

NickCao commented Mar 31, 2022

What will happen if I run this on a pre 5.1 kernel?

@vcunat
Copy link
Member Author

vcunat commented Mar 31, 2022

I have no idea beyond that announcement. They say "full support", so I'd hope that with 5.0 you might not run into any problems even.

symphorien
symphorien reviewed Apr 3, 2022
View reviewed changes
@vcunat @symphorien
powerdns: fix typo
6b7bd8d 
Co-authored-by: Guillaume Girol <[email protected]>
@ofborg ofborg bot requested review from Mic92, NickCao and disassembler April 3, 2022 16:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 3, 2022
@symphorien symphorien merged commit 45a5514 into NixOS:staging-next Apr 5, 2022
@vcunat vcunat deleted the p/powerdns-32bit branch April 5, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@symphorien symphorien symphorien left review comments

@disassembler disassembler Awaiting requested review from disassembler

@NickCao NickCao Awaiting requested review from NickCao

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcunat @NickCao @symphorien