Skip to content

nixos/gnome: Re-enable VTE shell integration#166156

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
andersk:gnome-vte-shell
Mar 29, 2022
Merged

nixos/gnome: Re-enable VTE shell integration#166156
jtojnar merged 1 commit intoNixOS:masterfrom
andersk:gnome-vte-shell

Conversation

@andersk
Copy link
Contributor

@andersk andersk commented Mar 28, 2022

Description of changes

Commit 7addb1c (#160343) disabled this as a side effect of switching gnome-terminal to gnome-console, but it’s still useful for gnome-console.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@andersk
nixos/gnome: Re-enable VTE shell integration
5abbb68 
Commit 7addb1c disabled this as a
side effect of switching gnome-terminal to gnome-console, but it’s
still useful for gnome-console.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk andersk mentioned this pull request Mar 28, 2022
Merged
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 28, 2022
@andersk andersk requested review from jtojnar and vcunat March 28, 2022 23:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 28, 2022
@jtojnar jtojnar merged commit 00e27c7 into NixOS:master Mar 29, 2022
@andersk andersk deleted the gnome-vte-shell branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andersk @jtojnar