Skip to content

gsettings-desktop-schemas: clear out broken dark background URL#166094

Merged
jtojnar merged 2 commits intoNixOS:stagingfrom
jtojnar:g-s-d-dark-background
Mar 29, 2022
Merged

gsettings-desktop-schemas: clear out broken dark background URL#166094
jtojnar merged 2 commits intoNixOS:stagingfrom
jtojnar:g-s-d-dark-background

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 28, 2022 •
edited
Loading

Description of changes

Fixes broken background in GNOME 42 in dark mode. Also needs a module change.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 28, 2022
@ofborg ofborg bot requested review from amaxine, dasj19 and hedning March 28, 2022 15:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 28, 2022
@jtojnar jtojnar changed the base branch from master to staging March 28, 2022 15:52
@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 28, 2022
@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 6.topic: xfce The Xfce Desktop Environment 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 28, 2022
This was referenced Mar 28, 2022
Merged
Merged
@jtojnar jtojnar merged commit ef9896e into NixOS:staging Mar 29, 2022
@jtojnar jtojnar deleted the g-s-d-dark-background branch March 29, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobby285271 bobby285271 bobby285271 approved these changes

@dasj19 dasj19 Awaiting requested review from dasj19

@amaxine amaxine Awaiting requested review from amaxine

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtojnar @bobby285271