make-bootstrap-tools-cross: fix typo which prevents hydra eval#165733
make-bootstrap-tools-cross: fix typo which prevents hydra eval#165733sternenseemann merged 1 commit intomasterfrom unknown repository
Conversation
|
@Ericson2314, please take a look at this when you get a chance. You are familiar with the background here. Also, can anybody explain to me how to reproduce exactly what expression Hydra is evaluating here? It isn't simply since that evaluates to an attrset, not a derivation (so the command above does nothing). Clearly there is much more "input" to this job than is shown on the webpage; at minimum you need plus you need to pass a value for |
|
One other question: in nixlang, how exactly does one go about figuring out all the places in a codebase that reference a given identifier? In Haskell, ML, Rust, and even C/C++ I'm accustomed to simply deleting a declaration and then recompiling to figure out "what uses this declaration?" The compiler will tell me all the places where it is used by producing a compilation error for each of those places. How do I do this in nixlang? |
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg said:
Um, I don't think this is my fault. |
|
@ofborg eval |
(success) Weird. Nothing changed between the two evaluations. |
ofborg merges the PR into master before evaluating, so probably master fixed the eval issue in the meantime. |
i fixed the eval issue in a another pr |
ghost
requested a review
from
|
Please squash the commits into one. |
Done. |
|
Commit name is wrong |
|
Sorry about that, fixed now. |
When implementing this reviewer request: #161158 (comment) to move mips64el-unknown-linux-* from platforms.nix to examples.nix, I neglected to update the reference in make-bootstrap-tools-cross.nix. As a result, the hydra jobs to generate a bootstrap tarball for mips64el are not running: https://hydra.nixos.org/eval/1750828?filter=mips&compare=1750620&full=#tabs-errors This commit fixes the problem, so the hydra job can run. Once it does, I will submit a PR adding the trusted bootstrap tarball hash to pkgs/stdenv/linux/bootstrap-files/. Co-authored-by: sterni <[email protected]>
|
Thank you. And, again, apologies for how I screwed this up in the initial PR. Still interested in knowing if nixlang has a "where is this declaration used" mechanism. I'll ask on the Discourse forum. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
ghost
mentioned this pull request
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Hydra's |
|
Narrowed it down to this. If somebody could kick Hydra in the appropriate way to force a rebuild I would appreciate it. |
3 participants
When implementing this reviewer request to move mips64el-unknown-linux-* from platforms.nix to examples.nix, I
neglected to update the reference in make-bootstrap-tools-cross.nix.
As a result, the hydra jobs to generate a bootstrap tarball for
mips64el are not running:
https://hydra.nixos.org/eval/1750828?filter=mips&compare=1750620&full=#tabs-errors
This commit fixes the problem, so the hydra job can run. Once it
does, I will submit a PR adding the trusted bootstrap tarball hash to
pkgs/stdenv/linux/bootstrap-files/.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes