Skip to content

llvmPackages_latest: 13 -> 14#165701

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
primeos:llvmPackages_latest
Aug 12, 2022
Merged

llvmPackages_latest: 13 -> 14#165701
alyssais merged 1 commit intoNixOS:stagingfrom
primeos:llvmPackages_latest

Conversation

@primeos
Copy link
Member

@primeos primeos commented Mar 24, 2022 •
edited
Loading

Description of changes

This is likely not ready yet (some LLVM 14 packages might still be marked as broken) but as a reminder/TODO (#165520). I haven't done any testing yet and don't really have time/motivation to push this forward. Does someone else have time and motivation for this? Feel free to replace my PR. Whoever tests this should definitely take the credit for that work!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Mar 24, 2022

cc (FYI) @lovek323 @7c6f434c @dtzWill @sternenseemann @Ericson2314

@primeos primeos mentioned this pull request Mar 24, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 24, 2022
This was referenced Mar 31, 2022
Closed
Closed
This was referenced Apr 30, 2022
Open
Closed
@vcunat
Copy link
Member

vcunat commented Jun 3, 2022

I don't know... perhaps packages that can't use llvmPackages_latest shouldn't be pinned to it anymore? I find it weird that _latest doesn't point to the latest llvm*.

@primeos
Copy link
Member Author

primeos commented Jun 4, 2022

It should be ready now, at least I've seen lots of fixes for LLVM 14 in the meantime, so I expect only very few breakages.
When excluding mesa, this might not trigger that many rebuilds so it might even be possible to use nixpkgs-review for testing this. However, I currently don't have a powerful enough builder anymore so I cannot verify it that way.
I'm not sure what's the best way to move this forward... :o

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 8, 2022

I am fixing the remaining gnu install dirs. I am sorry I didn't do this long ago.

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 8, 2022

Done in #176925

@Flakebi
Copy link
Member

Flakebi commented Jun 20, 2022

Ignoring mesa (by pinning it to llvmPackages_13), there is only a single regression: ccls
I think we can just pin that to llvmPackages_13? cc @Mic92 @tobim

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python310Packages.tiledb
  • python39Packages.tiledb
1 package failed to build:
  • ccls
18 packages built:
  • bat-extras.prettybat
  • clang-analyzer
  • clang-tools
  • cloudcompare
  • cvise
  • grass
  • lldb
  • lldb_13
  • mold
  • nominatim
  • pdal
  • pdal_2_3
  • qgis
  • qgis-ltr
  • tiledb
  • txr
  • umr
  • vscode-extensions.ms-vscode.cpptools

Mesa builds fine as well, I didn’t try using it.

@Ericson2314 Ericson2314 marked this pull request as ready for review June 20, 2022 16:13
@7c6f434c
Copy link
Member

7c6f434c commented Jul 26, 2022

@ofborg build ccls

@7c6f434c
Copy link
Member

7c6f434c commented Jul 26, 2022

@primeos if it ends up still failing, maybe indeed pin it?

@winterqt
Copy link
Member

winterqt commented Aug 11, 2022

@Flakebi What did you do to get that small list of packages to build w/ nixpkgs-review? I can only get the ~1200 packages to start building on my system :/

@alyssais
Copy link
Member

alyssais commented Aug 12, 2022

ccls seems to build fine with LLVM 14 now. Maybe because of #183987? So I think this is ready to go.

@alyssais alyssais merged commit af21e11 into NixOS:staging Aug 12, 2022
@Flakebi
Copy link
Member

Flakebi commented Aug 12, 2022

@Flakebi What did you do to get that small list of packages to build w/ nixpkgs-review? I can only get the ~1200 packages to start building on my system :/

I patched my nixpkgs so that mesa uses llvmPackages = llvmPackages_13 as a dependency instead of llvmPackages_latest in pkgs/top-level/all-packages.nix, then ran nixpkgs-review wip.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@primeos @vcunat @Ericson2314 @Flakebi @7c6f434c @winterqt @alyssais @rrbutani