fixes for mips cross compiling toolchains#165020
Conversation
Mic92
requested review from
Ericson2314,
alyssais,
matthewbauer and
nbp
as code owners
|
Exception: error: Unknown CPU type: mipsisa32r6; type: nix::ThrownError |
|
cc @a-m-joseph |
ofborg
bot
added
10.rebuild-darwin: 0
github-actions
bot
added
the
6.topic: golang
Mic92
changed the title
|
This is my first time using github to do a code review; if I did something stupid I apologize.
|
|
Hi, I can't figure out how to suggest specific changes. Please consider the changes found in the topmost commit of this branch: A lot of the messiness here is because nixpkgs treats gnu 5-tuples as 4-tuples, and mixes up the libc with the abi. So we have a lot of code duplication where adding an abi means you have to add it multiple times, once for each libc. |
lib/systems/doubles.nix
Outdated
There was a problem hiding this comment.
By adding these two tuples to the list in lib/systems/doubles.nix you are telling nixpkgs that they evaluate. However, as you've noticed, they don't evaluate :) So, you should not probably not add them here until things evaluate.
There was a problem hiding this comment.
They evaluate and build stuff, see https://hercules-ci.com/github/nix-community/cross-toolchains.nix/jobs/79
lib/systems/platforms.nix
Outdated
There was a problem hiding this comment.
Why did you remove the abi attribute? Do you believe it is set incorrectly?
See also this, which might at least partially resolve any errors you may have encountered while trying to use abi="o32".
There was a problem hiding this comment.
The commit messages points to an gentoo issue, where they choose a similar ABI: https://bugs.gentoo.org/515694#c2
With the current abi target gcc does not compile.
lib/tests/systems.nix
Outdated
There was a problem hiding this comment.
Likewise.
This is my first time using github for a review; is there some way I can indicate that one of my review comments applies to multiple lines in a given file, or to multiple chunks of code scattered across multiple files?
|
Can you provide a |
There was a problem hiding this comment.
Still can't figure out how to tell github that I suggest these changes.
$ git push git@github:NixOS/nixpkgs pull/165020/head
ERROR: Permission to NixOS/nixpkgs.git denied to a-m-joseph.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
The code is here: https://github.com/nix-community/cross-toolchains.nix/blob/main/flake.nix |
Mic92
force-pushed
the
fix-platforms
branch
2 times, most recently
from
104b9ac to
1471db9
Compare
|
No longer interested in investing time into MIPS. |
ghost
mentioned this pull request
|
Cross-builds to mips32 are now working, and the nix interpreter seccomp filters have been updated to allow mips32 binaries to execute in a sandbox on a mips64 host. |
2 participants
Those don't evaluate.
Description of changes
Current status: still building. Testing here: nix-community/cross-toolchains.nix#19
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes