Closed
Conversation
Member
|
@delroth seems like you forgot to update the |
Member
commit 2991c4b57cb7af31ef5aea46e02b2c75acd65cfe
Author: Pierre Bourdon <[email protected]>
Date: Sat Mar 12 17:12:33 2022 +0100
tpm2-tss: 3.0.3 -> 3.2.0
diff --git a/pkgs/development/libraries/tpm2-tss/default.nix b/pkgs/development/libraries/tpm2-tss/default.nix
index 5ab4ff3b413..caf00dcca77 100644
--- a/pkgs/development/libraries/tpm2-tss/default.nix
+++ b/pkgs/development/libraries/tpm2-tss/default.nix
@@ -2,6 +2,7 @@
, autoreconfHook, autoconf-archive, pkg-config, doxygen, perl
, openssl, json_c, curl, libgcrypt
, cmocka, uthash, ibm-sw-tpm2, iproute2, procps, which
+, shadow
}:
let
# Avoid a circular dependency on Linux systems (systemd depends on tpm2-tss,
@@ -14,17 +15,18 @@ in
stdenv.mkDerivation rec {
pname = "tpm2-tss";
- version = "3.0.3";
+ version = "3.2.0";
src = fetchFromGitHub {
owner = "tpm2-software";
repo = pname;
rev = version;
- sha256 = "106yhsjwjadxsl9dqxywg287mdwsksman02hdalhav18vcnvnlpj";
+ sha256 = "1jijxnvjcsgz5yw4i9fj7ycdnnz90r3l0zicpwinswrw47ac3yy5";
};
nativeBuildInputs = [
autoreconfHook autoconf-archive pkg-config doxygen perl
+ shadow
];
# cmocka is checked / used(?) in the configure script
@@ -85,6 +87,6 @@ stdenv.mkDerivation rec {
homepage = "https://github.com/tpm2-software/tpm2-tss";
license = licenses.bsd2;
platforms = platforms.linux;
- maintainers = with maintainers; [ delroth ];
+ maintainers = with maintainers; [ ];
};
}something like this would be my suggestion |
Contributor
Author
|
Oops, indeed, thanks for the review. Please feel free to resend this PR (with yourself as author, at that point you did all the work :) ), I won't have the time in the next few days to take care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Bump tpm2-tss to its latest upstream release. Tested with
nix-build -A . systemdwith this change rebased on master.Removing myself from maintainers, I don't want to deal with derivations that have to have their changes go through staging.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes