Skip to content

Comments

pip-audit: init at 2.0.0#163588

Merged
fabaff merged 6 commits intoNixOS:stagingfrom
fabaff:pip-audit
May 4, 2022
Merged

pip-audit: init at 2.0.0#163588
fabaff merged 6 commits intoNixOS:stagingfrom
fabaff:pip-audit

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Mar 10, 2022 •
edited
Loading

Description of changes

Tool for scanning Python environments for known vulnerabilities

https://github.com/trailofbits/pip-audit.

Related to #81418

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners March 10, 2022 18:09
@fabaff fabaff marked this pull request as draft March 10, 2022 18:09
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 10, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 10, 2022
@ofborg ofborg bot requested review from costrouc and mweinelt March 10, 2022 18:23
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 10, 2022
mweinelt
mweinelt reviewed Mar 10, 2022
View reviewed changes
@fabaff fabaff force-pushed the pip-audit branch 3 times, most recently from 8490406 to aac3941 Compare March 10, 2022 19:20
milahu
milahu reviewed Mar 11, 2022
View reviewed changes
milahu
milahu reviewed Mar 11, 2022
View reviewed changes
milahu
milahu reviewed Mar 11, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 12, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 12, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 12, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 12, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 12, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 21, 2022
View reviewed changes
@fabaff fabaff marked this pull request as ready for review March 25, 2022 16:06
SuperSandro2000
SuperSandro2000 reviewed Mar 26, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 26, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 26, 2022
View reviewed changes
@fabaff
Copy link
Member Author

fabaff commented Apr 28, 2022

#162222 (comment) doesn't seems to work for me.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft labels Apr 28, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 29, 2022

git rebase --onto=$(git merge-base upstream/master upstream/staging) HEAD~4

Make sure to replace upstream with the right remote name.

@ofborg ofborg bot removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Apr 30, 2022
@ofborg ofborg bot requested a review from costrouc April 30, 2022 16:12
@ofborg ofborg bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 30, 2022
@fabaff
Copy link
Member Author

fabaff commented May 3, 2022 •
edited
Loading

@ofborg build pip-audit

@fabaff fabaff merged commit f450d5b into NixOS:staging May 4, 2022
@fabaff fabaff deleted the pip-audit branch May 4, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

+1 more reviewer

@milahu milahu milahu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabaff @SuperSandro2000 @mweinelt @milahu