Skip to content

wireplumber: backport a hang fix#163060

Merged
jonringer merged 1 commit intoNixOS:masterfrom
K900:wireplumber-fix
Mar 8, 2022
Merged

wireplumber: backport a hang fix#163060
jonringer merged 1 commit intoNixOS:masterfrom
K900:wireplumber-fix

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Mar 6, 2022

Motivation for this change

Some applications (notably Steam) currently hang when attempting to play sound through pw-pulse. Backport a wireplumber fix for that. Upstream issue: https://gitlab.freedesktop.org/pipewire/wireplumber/-/issues/213

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Some applications (notably Steam) currently hang when attempting to
play sound through pw-pulse. Backport a wireplumber fix for that.
@K900 K900 requested review from arcnmx, jansol, jonringer and jtojnar March 6, 2022 20:42
@K900
Copy link
Contributor Author

K900 commented Mar 6, 2022

Also ping @jonringer as resident Steam maintainer.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 6, 2022
Copy link
Contributor

@jansol jansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes audio in unigine-valley.

Copy link
Member

@arcnmx arcnmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe I was affected by the issue that this addresses but applying the fix hasn't broken anything here so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants